-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for proxying HTTPS server connections on the client side #192
Comments
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
Relates to akka/akka#17976 |
+1 |
+1 |
Logging a "very big" +1 here, we may want to think how and when we could address this. |
+1 |
+1 |
+1 |
Logging another +1 (for my reference, sorry for the noise) |
+1 |
+1 |
+1 |
+1 |
+1000 |
Akka team won't be able (time wise) to pick up this issue in the short-term, so we'd like to encourage you to try to contribute this feature, or contact us if you'd like sponsor its development. |
+1 |
+1 |
+1 |
+1 |
+1 |
1 similar comment
+1 |
+1 |
Note that a PR is worth more than a million +1s. (Also please use the reaction button instead of spamming this ticket with +1 comments, thanks!) |
+1, but if the +1 is not enough to express interest, I can always write: PLEASE FIX THIS, I AM INTERESTED IN SEEING THIS FIXED. |
I was playing around this issue and managed to complete HTTPS request via proxy. Here is my code: https://github.com/akka/akka-http/compare/master...note:192-https-proxy?expand=1. It's not ready to be a PR, there is still a lot of work to do, I am mostly sharing it for early validation. So the solution boils down to having additional |
Great work, @note for taking a stab at it. I just opened another PR yesterday which could be used as groundwork for it: it allows to redefine the transport the pool (or a single client connection) uses to access a host. The only predefined transport so far would be the existing TCP transport. Your HTTPS proxy support could be an The basic change you would need to do is to include your underlying TCP connection to the HTTPS proxy into your code. Apart from that no changes to the existing http-core infrastructure would be necessary. WDYT? It certainly looks promising, so please open a PR. I'll try to merge my PR this week so you can rebase on top of that. |
For reference, the pluggable transport PR #917 |
@jrudolph Thanks for your feedback, your PR seems very helpful - with that I think there's a great chance I will be able to implement Https proxy without touching |
Great, thanks, @note. We (and lots of other people) are looking forward to it. |
…https proxy support
…https proxy support
…https proxy support
Monday Oct 27, 2014 at 15:52 GMT
Originally opened as akka/akka#16153
Required for one connection:
CONNECT target.host:443 HTTP/1.1
request to the proxy2xx
response (afterwards all communication on the connection will be directly tunneled through to the target host)This feature should likely be implemented on the level of host-level client-side API as in most cases you'll want a managed connection pool to the proxy.
Some pointers:
The text was updated successfully, but these errors were encountered: