getForKeyCaseInsensitive not working on HttpMethods.

[liljaylj]

HttpMethods.getForKeyCaseInsensitive("POST") gives None, should be Some(HttpMethod(GET))

The reason is that when HttpMethods registers its members it uses upper case keys

akka-http/akka-http-core/src/main/scala/akka/http/scaladsl/model/HttpMethod.scala

Line 57 in 240d9ac

private def register(method: HttpMethod): HttpMethod = register(method.value, method)

... but when invoking getForKeyCaseInsensitive under the hood it applies toRootLowerCase on key

akka-http/akka-http-core/src/main/scala/akka/http/impl/util/ObjectRegistry.scala

Line 27 in 240d9ac

getForKey(conv(key.toRootLowerCase))

My recommendations are either store keys in lower case or override getForKeyCaseInsensitive and replace toRootLowerCase with toUpperCase(Locale.ROOT)

override def getForKeyCaseInsensitive(key: String)(implicit conv: String <:< String) : Option[HttpMethod] =
    getForKey(key.toUpperCase(Locale.ROOT))

[raboof]

@liljaylj huh, good observation! I suppose replacing toRootLowerCase with toUpperCase(Locale.ROOT) would be the most unobtrusive change, unless we have reason to believe this method is performance-critical? Would you like to propose the change as a PR?