Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Caffeine to 2.7 #2443

Closed
ben-manes opened this issue Mar 4, 2019 · 1 comment · Fixed by #2496
Closed

Upgrade Caffeine to 2.7 #2443

ben-manes opened this issue Mar 4, 2019 · 1 comment · Fixed by #2496
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted help wanted Identifies issues that the core team will likely not have time to work on t:caching Issues related to the akka-http-caching module
Milestone
10.1.9

Comments

@ben-manes
Copy link

LfuCache currently uses a dummy loader to comply with the API and uses only the manual loading methods. Based on this and similar feedback, we now offer AsyncCache to avoid this workaround.

Another benefit is that the eviction policy is now adaptive. It still initially biases towards frequency, but will reconfigure itself based on the workload characteristics. I don't know the typical characteristics for an http cache, but it may be beneficial. I believe there is still some fine tuning needed for tiny caches (e.g. less than 100) that I'll look into for a patch release.
@jrudolph jrudolph added help wanted Identifies issues that the core team will likely not have time to work on 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:caching Issues related to the akka-http-caching module labels Mar 5, 2019
@jrudolph
Copy link
Member

jrudolph commented Mar 5, 2019

Sounds good. Thanks for letting us know, @ben-manes.

@jrudolph jrudolph added this to the 10.1.8 milestone Mar 5, 2019
@raboof raboof modified the milestones: 10.1.8, 10.1.9 Mar 15, 2019
@jiminhsieh jiminhsieh mentioned this issue Mar 28, 2019
Merged
jrudolph pushed a commit that referenced this issue May 8, 2019
@jiminhsieh @jrudolph
Upgrade caffeine to 2.7 which removes need for dummyLoader (#2496)
df401f1 
Fixes #2443.
franktominc pushed a commit to franktominc/akka-http that referenced this issue Jun 12, 2019
@jiminhsieh @franktominc
Upgrade caffeine to 2.7 which removes need for dummyLoader (akka#2496)
604dbef 
Fixes akka#2443.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted help wanted Identifies issues that the core team will likely not have time to work on t:caching Issues related to the akka-http-caching module
Projects
None yet
Milestone
10.1.9
Development

Successfully merging a pull request may close this issue.

Upgrade caffeine to 2.7 jiminhsieh/akka-http
3 participants
@jrudolph @raboof @ben-manes