Java DSL cannot create streaming marshaller / unmarshaller

[akka-ci]

Issue by jypma
Thursday Sep 01, 2016 at 13:37 GMT
Originally opened as akka/akka#21340

---

The Java Marshaller and Unmarshaller classes are missing a few of the scala variants that make it impossible to write streaming marshallers and unmarshallers in Java.

I've already written the needed additions for Marshaller and Unmarshaller.

Shall I create a PR?

[akka-ci]

Comment by ktoso
Thursday Sep 01, 2016 at 13:56 GMT

---

Hm, what specifically do you mean saying "streaming marshaller / unmarshaller"?
But yeah, please PR! :)

[akka-ci]

Comment by jypma
Thursday Sep 01, 2016 at 14:08 GMT

---

PR created. Turns out the "streaming marshaller" can in fact be written in plain Java. That leaves just the unmarshaller side, plus a few random other fixes.

[akka-ci]

Comment by jypma
Monday Sep 05, 2016 at 08:35 GMT

---

@ktoso tests passed on the PR (akka/akka#21341). How do you feel about the additions?

[akka-ci]

Comment by ktoso
Monday Sep 05, 2016 at 08:37 GMT

---

Had a crazy week, back to reviewing.

[jlprat]

Shouldn't this be closed as the PR referenced here is long time closed?

[ktoso]

Seems it did not make it over to Akka-HTTP during repo change: akka/akka#21341 (comment)

@jypma are you still interested in making this happen?

[jrudolph]

Afaics this has been fixed by now.