Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP/2: MemoryLeak in AlpnSwitcher #886

Closed
jrudolph opened this issue Feb 21, 2017 · 1 comment
Closed

HTTP/2: MemoryLeak in AlpnSwitcher #886

jrudolph opened this issue Feb 21, 2017 · 1 comment
Assignees
@ktoso
Labels
bug t:http2 Issues related to support HTTP2
Projects
Bug Hunting
Milestone
10.0.6

Comments

@jrudolph
Copy link
Member

AlpnSwitcher currently doesn't propagate connection closure to inner substreams. This leads to the implementation staying alive after the connection has been closed.
@jrudolph jrudolph added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted bug t:http2 Issues related to support HTTP2 labels Feb 21, 2017
@jrudolph jrudolph added this to the Final HTTP/2 milestone Feb 21, 2017
@jrudolph jrudolph added this to Backlog in Bug Hunting Feb 27, 2017
@ktoso ktoso added the 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding label Apr 25, 2017
@ktoso
Copy link
Member

ktoso commented Apr 28, 2017

Taking a stab at it

@ktoso ktoso added 3 - in progress Someone is working on this ticket and removed 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted labels Apr 28, 2017
ktoso added a commit to ktoso/akka-http that referenced this issue May 1, 2017
@ktoso
=h2 akka#886 fix leaks in ALPN switcher
6050870 
This technically is very similar to CoupledTerminationFlow,
however since it's "sub" sources/sinks we could not directly use that.
@ktoso ktoso mentioned this issue May 1, 2017
Merged
ktoso added a commit to ktoso/akka-http that referenced this issue May 1, 2017
@ktoso
=h2 akka#886 fix leaks in ALPN switcher
bf7b57b 
This technically is very similar to CoupledTerminationFlow,
however since it's "sub" sources/sinks we could not directly use that.
@ktoso ktoso self-assigned this May 1, 2017
ktoso added a commit to ktoso/akka-http that referenced this issue May 2, 2017
@ktoso
=h2 akka#886 fix leaks in ALPN switcher
e1ae587 
This technically is very similar to CoupledTerminationFlow,
however since it's "sub" sources/sinks we could not directly use that.
ktoso added a commit that referenced this issue May 2, 2017
@ktoso
=h2 #886 fix leaks in ALPN switcher
6f793b6 
This technically is very similar to CoupledTerminationFlow,
however since it's "sub" sources/sinks we could not directly use that.
@ktoso ktoso removed 3 - in progress Someone is working on this ticket 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding labels May 2, 2017
ktoso added a commit that referenced this issue May 3, 2017
@ktoso
=h2 #886 Remove unnecessary complete call
9c3b104 
Follow up from #886's PR
@ktoso ktoso mentioned this issue May 3, 2017
Merged
ktoso added a commit that referenced this issue May 3, 2017
@ktoso
=h2 #886 Remove unnecessary complete call
10c6530 
Follow up from #886's PR
@ktoso ktoso modified the milestones: HTTP/2 for Play, 10.0.6 May 3, 2017
@jrudolph jrudolph mentioned this issue May 8, 2017
Open
@jonas jonas moved this from Backlog to Done in Bug Hunting May 16, 2017
tomrf1 pushed a commit to tomrf1/akka-http that referenced this issue Aug 13, 2017
@ktoso @tomrf1
=h2 akka#886 fix leaks in ALPN switcher
4a614c5 
This technically is very similar to CoupledTerminationFlow,
however since it's "sub" sources/sinks we could not directly use that.
tomrf1 pushed a commit to tomrf1/akka-http that referenced this issue Aug 13, 2017
@ktoso @tomrf1
=h2 akka#886 Remove unnecessary complete call
d8e5800 
Follow up from akka#886's PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ktoso ktoso

Labels
bug t:http2 Issues related to support HTTP2
Projects
No open projects
Bug Hunting
Done
Milestone
10.0.6
Development

No branches or pull requests
2 participants
@jrudolph @ktoso