Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Status code misses trailing space' Error && Handling Status lines without phrasing #981

Closed
sheinbergon opened this issue Mar 20, 2017 · 2 comments
Closed

'Status code misses trailing space' Error && Handling Status lines without phrasing #981

sheinbergon opened this issue Mar 20, 2017 · 2 comments
Labels
help wanted Identifies issues that the core team will likely not have time to work on t:client Issues related to the HTTP Client t:core Issues related to the akka-http-core module
Milestone
10.0.6

Comments

@sheinbergon
Copy link

sheinbergon commented Mar 20, 2017 •
edited
Loading

Hello.

I've recently came across an API that didn't provide fully HTTP 1.1 complaint status lines in case of errors, meaning no phrasing ('HTTP/1.1 400' when it should be 'HTTP/1.1 400 Bad Request', for example).

Though there's no doubt it's an improper implementation, other client libraries/command line tools seem to be able to cope with it, while akka-http breaks with an error emitted from HttpResponseParser (line 99-100).

Is there any chance this behavior is considered to strict and/or could/should be opted out?
@jrudolph jrudolph added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted help wanted Identifies issues that the core team will likely not have time to work on t:client Issues related to the HTTP Client t:core Issues related to the akka-http-core module labels Mar 21, 2017
@jrudolph
Copy link
Member

Yes, I think that it might make sense to be loosened up.

@sheinbergon
Copy link
Author

@jrudolph OK, so how do you want to make progress from here? What's the preferred method of fixing this issue in your opinion?

athieriot added a commit to athieriot/akka-http that referenced this issue Mar 23, 2017
@athieriot
Make Response parser more relaxed on reason message akka#981
da65084 
Proposal for issue akka#981 that will allow, in ParsingMode.Relax only, to
parse a non-standard Http Response which does not contain a status
message.

Example: 'HTTP/1.1 400' instead of 'HTTP/1.1 400 Bad Request'
@athieriot athieriot mentioned this issue Mar 23, 2017
Closed
athieriot added a commit to athieriot/akka-http that referenced this issue Mar 23, 2017
@athieriot
Make Response parser more relaxed on reason message akka#981
dad5b67 
Proposal for issue akka#981 that will allow to parse a non-standard
Http Response which does not contain a status message.

Example: 'HTTP/1.1 400' instead of 'HTTP/1.1 400 Bad Request'
@athieriot athieriot mentioned this issue Mar 23, 2017
Merged
athieriot added a commit to athieriot/akka-http that referenced this issue Mar 27, 2017
@athieriot
Make Response parser more relaxed on reason message akka#981
918a210 
Proposal for issue akka#981 that will allow to parse a non-standard
Http Response which does not contain a status message.

Example: 'HTTP/1.1 400' instead of 'HTTP/1.1 400 Bad Request'
@jrudolph jrudolph added this to the 10.0.6 milestone Mar 30, 2017
@ktoso ktoso removed the 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted label Mar 30, 2017
tomrf1 pushed a commit to tomrf1/akka-http that referenced this issue Aug 13, 2017
@athieriot @tomrf1
Make Response parser more relaxed on reason message akka#981 (akka#989)
2108dd9 
Proposal for issue akka#981 that will allow to parse a non-standard
Http Response which does not contain a status message.

Example: 'HTTP/1.1 400' instead of 'HTTP/1.1 400 Bad Request'

Fixes akka#981.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Identifies issues that the core team will likely not have time to work on t:client Issues related to the HTTP Client t:core Issues related to the akka-http-core module
Projects
None yet
Milestone
10.0.6
Development

No branches or pull requests
3 participants
@jrudolph @ktoso @sheinbergon