Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

=doc #1199 reference security announcements and release notes in both java and scala toc #1201

Merged
merged 5 commits into from Jun 19, 2017
Merged

=doc #1199 reference security announcements and release notes in both java and scala toc #1201

merged 5 commits into from Jun 19, 2017

Conversation

jrudolph
Copy link
Member

Fixes #1199.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Jun 14, 2017
@akka-ci
Copy link

akka-ci commented Jun 14, 2017

Test PASSed.

raboof
raboof approved these changes Jun 14, 2017
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we could also move them to scala/http and add a symlink from the java side like we do for the Akka docs?

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels Jun 14, 2017
@akka-ci
Copy link

akka-ci commented Jun 14, 2017

Test PASSed.

@jrudolph
Copy link
Member Author

Ah I see. Interesting idea. That would also solve that clicking on this link from the Java side of things switches over to the Scala side. If you like, you could follow up on this next week.

@jrudolph jrudolph added the 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding label Jun 14, 2017
@raboof raboof self-assigned this Jun 19, 2017
@raboof raboof added this to the 10.0.8 milestone Jun 19, 2017
@akka-ci akka-ci added validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels Jun 19, 2017
@akka-ci
Copy link

akka-ci commented Jun 19, 2017

Test FAILed.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR that is currently being validated by Jenkins labels Jun 19, 2017
@akka-ci
Copy link

akka-ci commented Jun 19, 2017

Test PASSed.

@akka-ci akka-ci added the validating PR that is currently being validated by Jenkins label Jun 19, 2017
@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels Jun 19, 2017
@akka-ci
Copy link

akka-ci commented Jun 19, 2017

Test PASSed.

@raboof
Copy link
Member

raboof commented Jun 19, 2017

(for the migration guides I'm including all guides for both Scala and Java, that should be okay in this case. If we ever 'really' have a section that only applies to one group we might have to add support for that to the ToC component, see lightbend/paradox#128 )

@2m 2m merged commit 4d6fc48 into akka:master Jun 19, 2017
@2m 2m removed the 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding label Jun 19, 2017
tomrf1 pushed a commit to tomrf1/akka-http that referenced this pull request Aug 13, 2017
@jrudolph @tomrf1
=doc akka#1199 reference security announcements and release notes in …
170d606 
…both java and scala toc (akka#1201)

=doc akka#1199 reference security announcements and release notes in both java and scala toc

* add small paragraph about ClientTransport API/SPI changes
* Use symlinks to share docs between scala and java
* Merge migration guides
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof approved these changes

@2m 2m 2m approved these changes

Assignees

@raboof raboof

Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
10.0.8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jrudolph @akka-ci @raboof @2m