Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

=htc #380 TLS should close connection when instructed by stream completion #1822

Merged
merged 3 commits into from
Feb 2, 2018
Merged

=htc #380 TLS should close connection when instructed by stream completion #1822

merged 3 commits into from
Feb 2, 2018

Conversation

jrudolph
Copy link
Member

Thanks @nodefactory-bk for the reproducer.

Fixes #380.

@jrudolph
=htc delayCancellation should also apply for Http().serverLayer
58e493b 
Before it was only applied for all the other server APIs.
@jrudolph
=htc akka#380 TLS should close connection when instructed by stream c…
3b9735f 
…ompletion

Before introduction of the `delayCancellation` stage TLS closing worked
despite of the default `TLSCLosing.ignoreComplete` mode somewhat
accidentally because cancellation would close the TCP connection.

With the introduction of `delayCancellation`, stream completion is the signal
to act on.

Without this fix, the server TLS side does not close the connection
eagerly but only the idle-timeout will do so later on.
@jrudolph jrudolph mentioned this pull request Jan 29, 2018
Closed
@akka-ci akka-ci added validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR that is currently being validated by Jenkins labels Jan 29, 2018
@akka-ci
Copy link

akka-ci commented Jan 29, 2018

Test FAILed.

@jrudolph
Copy link
Member Author

Unrelated: header check failed.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR that is currently being validated by Jenkins labels Jan 29, 2018
@akka-ci
Copy link

akka-ci commented Jan 29, 2018

Test PASSed.

@jrudolph jrudolph added the 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding label Feb 1, 2018
@jrudolph jrudolph merged commit cbc8704 into akka:master Feb 2, 2018
@jrudolph jrudolph deleted the jr/380-close-delim-stuck branch February 2, 2018 10:20
@jrudolph jrudolph mentioned this pull request Dec 19, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanandren johanandren johanandren approved these changes

Assignees
No one assigned
Labels
2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrudolph @akka-ci @johanandren