Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0-backport] TLS closing issue fixes #2344

Merged
merged 2 commits into from
Dec 21, 2018
Merged

[10.0-backport] TLS closing issue fixes #2344

merged 2 commits into from
Dec 21, 2018

Conversation

jrudolph
Copy link
Member

Refs #2329

@jrudolph
[backport] =htc delayCancellation should also apply for Http().server…
b24e71e 
…Layer

Before it was only applied for all the other server APIs.

(cherry picked from commit 58e493b)
@jrudolph
[backport] =htc akka#380 TLS should close connection when instructed …
b4e3aa3 
…by stream completion

Before introduction of the `delayCancellation` stage TLS closing worked
despite of the default `TLSCLosing.ignoreComplete` mode somewhat
accidentally because cancellation would close the TCP connection.

With the introduction of `delayCancellation`, stream completion is the signal
to act on.

Without this fix, the server TLS side does not close the connection
eagerly but only the idle-timeout will do so later on.

(cherry picked from commit 3b9735f)
@jrudolph jrudolph mentioned this pull request Dec 20, 2018
Closed
4 tasks
@jrudolph jrudolph changed the title Backport TLS closing issue fixes [10.0-backport] TLS closing issue fixes Dec 20, 2018
@jrudolph jrudolph added this to the 10.0.15 milestone Dec 20, 2018
@akka-ci akka-ci added validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR that is currently being validated by Jenkins labels Dec 20, 2018
@akka-ci
Copy link

akka-ci commented Dec 20, 2018

Test FAILed.

@jrudolph jrudolph added the 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding label Dec 20, 2018
@jrudolph
Copy link
Member Author

PLS BUILD

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR that is currently being validated by Jenkins labels Dec 20, 2018
@akka-ci
Copy link

akka-ci commented Dec 20, 2018

Test PASSed.

@raboof raboof merged commit 0427f93 into akka:release-10.0 Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof approved these changes

@johanandren johanandren johanandren approved these changes

Assignees
No one assigned
Labels
2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
10.0.15
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jrudolph @akka-ci @raboof @johanandren