New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0-backport] TLS closing issue fixes #2344

Merged
merged 2 commits into from Dec 21, 2018

Conversation

Projects
None yet
4 participants
@jrudolph
Copy link
Member

jrudolph commented Dec 20, 2018

Refs #2329

jrudolph added some commits Jan 29, 2018

[backport] =htc delayCancellation should also apply for Http().server…
…Layer

Before it was only applied for all the other server APIs.

(cherry picked from commit 58e493b)
[backport] =htc #380 TLS should close connection when instructed by s…
…tream completion

Before introduction of the `delayCancellation` stage TLS closing worked
despite of the default `TLSCLosing.ignoreComplete` mode somewhat
accidentally because cancellation would close the TCP connection.

With the introduction of `delayCancellation`, stream completion is the signal
to act on.

Without this fix, the server TLS side does not close the connection
eagerly but only the idle-timeout will do so later on.

(cherry picked from commit 3b9735f)

@jrudolph jrudolph referenced this pull request Dec 20, 2018

Closed

Backport a few fixes to 10.0.15 #2329

4 of 4 tasks complete

@jrudolph jrudolph changed the title Backport TLS closing issue fixes [10.0-backport] TLS closing issue fixes Dec 20, 2018

@jrudolph jrudolph added this to the 10.0.15 milestone Dec 20, 2018

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Dec 20, 2018

Test FAILed.

@jrudolph

This comment has been minimized.

Copy link
Member

jrudolph commented Dec 20, 2018

PLS BUILD

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Dec 20, 2018

Test PASSed.

@raboof

raboof approved these changes Dec 21, 2018

@raboof raboof merged commit 0427f93 into akka:release-10.0 Dec 21, 2018

3 checks passed

Jenkins PR Validation Test PASSed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment