Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error on Scala 2.12 #2350

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

johanandren
Copy link
Member

No description provided.

@@ -130,7 +130,7 @@ class DebuggingDirectivesExamplesSpec extends RoutingSpec {
}
def printResponseTime(log: LoggingAdapter) = {
val requestTimestamp = System.nanoTime
akkaResponseTimeLoggingFunction(log, requestTimestamp)(_)
akkaResponseTimeLoggingFunction(log, requestTimestamp) _
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm does this also work on 2.12.8? seemed this was changed intentionally at https://github.com/akka/akka-http/pull/2305/files#diff-d4736e778f9a72c660d7563af6fd6f6a

Copy link
Member Author

@johanandren johanandren Dec 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to change it to this to make it compile on 2.12.8, alternative would be (_)(_) since it has three parameter lists in total.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm that is weird... It was a warning and the builds passed...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That diff does the same as this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooopssss I think coffee really didn't kick in yet.... It's the same change indeed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh huh indeed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, this is the backport, sorry...

@akka-ci akka-ci added the validating PR that is currently being validated by Jenkins label Dec 21, 2018
@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Dec 21, 2018
@akka-ci
Copy link

akka-ci commented Dec 21, 2018

Test PASSed.

@raboof raboof merged commit ebac83e into akka:release-10.0 Dec 21, 2018
@johanandren johanandren deleted the wip-fix-compile-error-on-2.12 branch December 21, 2018 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants