-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation error on Scala 2.12 #2350
Fix compilation error on Scala 2.12 #2350
Conversation
@@ -130,7 +130,7 @@ class DebuggingDirectivesExamplesSpec extends RoutingSpec { | |||
} | |||
def printResponseTime(log: LoggingAdapter) = { | |||
val requestTimestamp = System.nanoTime | |||
akkaResponseTimeLoggingFunction(log, requestTimestamp)(_) | |||
akkaResponseTimeLoggingFunction(log, requestTimestamp) _ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm does this also work on 2.12.8? seemed this was changed intentionally at https://github.com/akka/akka-http/pull/2305/files#diff-d4736e778f9a72c660d7563af6fd6f6a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to change it to this to make it compile on 2.12.8, alternative would be (_)(_)
since it has three parameter lists in total.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmm that is weird... It was a warning and the builds passed...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That diff does the same as this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oooopssss I think coffee really didn't kick in yet.... It's the same change indeed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh huh indeed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, this is the backport, sorry...
Test PASSed. |
No description provided.