New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error on Scala 2.12 #2350

Merged
merged 1 commit into from Dec 21, 2018

Conversation

Projects
None yet
4 participants
@johanandren
Copy link
Member

johanandren commented Dec 21, 2018

No description provided.

@@ -130,7 +130,7 @@ class DebuggingDirectivesExamplesSpec extends RoutingSpec {
}
def printResponseTime(log: LoggingAdapter) = {
val requestTimestamp = System.nanoTime
akkaResponseTimeLoggingFunction(log, requestTimestamp)(_)
akkaResponseTimeLoggingFunction(log, requestTimestamp) _

This comment has been minimized.

@raboof

raboof Dec 21, 2018

Member

Hmm does this also work on 2.12.8? seemed this was changed intentionally at https://github.com/akka/akka-http/pull/2305/files#diff-d4736e778f9a72c660d7563af6fd6f6a

This comment has been minimized.

@johanandren

johanandren Dec 21, 2018

Member

I had to change it to this to make it compile on 2.12.8, alternative would be (_)(_) since it has three parameter lists in total.

This comment has been minimized.

@jlprat

jlprat Dec 21, 2018

Member

mmm that is weird... It was a warning and the builds passed...

This comment has been minimized.

@johanandren

johanandren Dec 21, 2018

Member

That diff does the same as this?

This comment has been minimized.

@jlprat

jlprat Dec 21, 2018

Member

Oooopssss I think coffee really didn't kick in yet.... It's the same change indeed

This comment has been minimized.

@raboof

raboof Dec 21, 2018

Member

oh huh indeed

This comment has been minimized.

@raboof

raboof Dec 21, 2018

Member

ah, this is the backport, sorry...

@akka-ci akka-ci added the validating label Dec 21, 2018

@raboof

raboof approved these changes Dec 21, 2018

@akka-ci akka-ci added tested and removed validating labels Dec 21, 2018

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Dec 21, 2018

Test PASSed.

@raboof raboof merged commit ebac83e into akka:release-10.0 Dec 21, 2018

3 checks passed

Jenkins PR Validation Test PASSed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@johanandren johanandren deleted the johanandren:wip-fix-compile-error-on-2.12 branch Dec 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment