Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unidoc in the presence of macro's #2484

Merged
merged 1 commit into from Apr 2, 2019
Merged

Fix unidoc in the presence of macro's #2484

merged 1 commit into from Apr 2, 2019

Conversation

raboof
Copy link
Member

@raboof raboof commented Mar 26, 2019

No description provided.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Mar 26, 2019
@akka-ci
Copy link

akka-ci commented Mar 26, 2019

Test PASSed.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins and removed tested PR that was successfully built and tested by Jenkins labels Mar 26, 2019
@akka-ci akka-ci added needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR that is currently being validated by Jenkins labels Mar 26, 2019
@akka-ci
Copy link

akka-ci commented Mar 26, 2019

Test FAILed.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR that is currently being validated by Jenkins labels Mar 26, 2019
@akka-ci
Copy link

akka-ci commented Mar 26, 2019

Test PASSed.

johanandren
johanandren approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I guess

@raboof raboof merged commit 4900bf6 into master Apr 2, 2019
@raboof raboof deleted the unidoc branch April 2, 2019 07:33
franktominc pushed a commit to franktominc/akka-http that referenced this pull request Jun 12, 2019
@raboof @franktominc
Fix unidoc in the presence of macro's (akka#2484)
7bbf237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanandren johanandren johanandren approved these changes

Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raboof @akka-ci @johanandren