New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add modeled header for Content-Location #2540
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f90069b
Add modeled header for Content-Location
jypma a682c28
Add Content-Location parsing and add tests (and also fix rendering)
jrudolph 8def72d
add mima rule for scala 2.11
jrudolph 271029b
Merge remote-tracking branch 'origin/master' into HEAD
jrudolph File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
22 changes: 22 additions & 0 deletions
22
akka-http-core/src/main/java/akka/http/javadsl/model/headers/ContentLocation.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
/* | ||
* Copyright (C) 2009-2019 Lightbend Inc. <https://www.lightbend.com> | ||
*/ | ||
|
||
package akka.http.javadsl.model.headers; | ||
|
||
import akka.http.javadsl.model.Uri; | ||
|
||
/** | ||
* Model for the `ContentLocation` header. | ||
* Specification: https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html | ||
*/ | ||
public abstract class ContentLocation extends akka.http.scaladsl.model.HttpHeader { | ||
public abstract Uri getUri(); | ||
|
||
public static ContentLocation create(Uri uri) { | ||
return new akka.http.scaladsl.model.headers.Content$minusLocation(uri.asScala()); | ||
} | ||
public static ContentLocation create(String uri) { | ||
return create(Uri.create(uri)); | ||
} | ||
} |
2 changes: 2 additions & 0 deletions
2
...mima-filters/10.1.9.backwards.excludes/pr-2540-add-content-location-header-model.excludes
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
# change to internal class, only needed for Scala 2.11 | ||
ProblemFilters.exclude[ReversedMissingMethodProblem]("akka.http.impl.model.parser.SimpleHeaders.content-location") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, caught by the tests and fixed ;)