Merge pull request #2905 from jrudolph/improve-outgoing-request-stream-error #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akka-ci
added
validating
|
Test FAILed. !!! Couldn't read commit file !!! |
* now only logged as debug, the reasoning is that the error can be propagated to the response side and doesn't need to be logged as prominently * added the exception message to the message, the reasoning is that otherwise a stack trace will be logged but often only in the next line so it might get lost in a simple grep
jrudolph
force-pushed
the
improve-outgoing-request-stream-error
branch
from
afc1896
to
ea749d5
Compare
akka-ci
added
validating
|
Test PASSed. |
johanandren
approved these changes
Jan 23, 2020
jrudolph
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to the response side and doesn't need to be logged as prominently
a stack trace will be logged but often only in the next line so it might get
lost in a simple grep
It's different for response stream errors on the server side: in that case the server is already done with the response and cannot handle any error happening during streaming out the response. There, the best way might actually be to log an error.