Use SystemMaterializer in AkkaSpecWithMaterializer #3075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akka-ci
added
validating
|
Test FAILed. Pull request validation reportFailed Test SuitesTest result for 'akka-http-core / Pr-validation / ./ executeTests' |
jrudolph
force-pushed
the
system-materializer-in-test
branch
from
710ac28
to
f8aaaa0
Compare
|
I thought let's fix this quickly but it was actually quite a ride due to akka/akka#28691 and other issues with assertAllStagesStopped. |
akka-ci
added
validating
jrudolph
force-pushed
the
system-materializer-in-test
branch
from
f8aaaa0
to
7b10178
Compare
akka-ci
added
needs-attention
|
Test PASSed. |
* use a proper test setup * enable TLS tests Why was the extra materializer needed? To make sure assertAllStagesStopped doesn't stumble over long-running streams (server binding and pool). Now using assertAllStagesStopped is a bit useless as we force more of the background resources to terminate but still cannot hurt. If assertAllStagesStopped fails with weird errors (or just an ask timeout turns up), it's probably because TlsActor doesn't support assertAllStagesStopped. See akka/akka#28691
jrudolph
force-pushed
the
system-materializer-in-test
branch
from
7b10178
to
8ce3169
Compare
jrudolph
commented
Apr 22, 2020
| "Http client connections" must { | ||
| val address = Await.result( |
There was a problem hiding this comment.
Initialization has been moved to the bottom.
jrudolph
commented
Apr 22, 2020
| class ClientCancellationSpec extends AkkaSpecWithMaterializer { | ||
| // TODO document why this explicit materializer is needed here? |
There was a problem hiding this comment.
Extra materializer is not needed any more (see explanation in commit message)
akka-ci
added
validating
jrudolph
commented
Apr 22, 2020
| }) | ||
|
|
||
| "support cancellation in simple outgoing connection with TLS" in Utils.assertAllStagesStopped(new TestSetup { | ||
| pending |
There was a problem hiding this comment.
Didn't manage to fix this test here, since Utils.assertAllStagesStopped is completely broken with TlsModule in place, it was impossible for now to debug what's going on.
jrudolph
commented
Apr 22, 2020
| * A client transport that will rewrite the target address to a fixed address. This can be used | ||
| * to pretend to connect to akka.example.org which is required to connect to the example server certificate. | ||
| */ | ||
| def proxyTransport(realAddress: InetSocketAddress): ClientTransport = |
There was a problem hiding this comment.
Ported the trick we used in alpakka to be to test TLS hostname verification in tests.
akka-ci
added
tested
|
Test PASSed. |
raboof
approved these changes
May 11, 2020
jrudolph
added a commit
to jrudolph/akka-http
that referenced
this pull request
May 11, 2020
This reverts commit 15f108c.
ennru
pushed a commit
that referenced
this pull request
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently fails, pushing that here to make sure I remember to fix it enventually.