Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix request body line parsing: Issue #2581 #3076

Merged
merged 1 commit into from May 13, 2020
Merged

Fix request body line parsing: Issue #2581 #3076

merged 1 commit into from May 13, 2020

Conversation

cyburgee
Copy link
Contributor

  • Improved the heuristic for detecting end of line character(s)
  • Added tests for UndefinedEndOfLineConfiguration

References #2581

@lightbend-cla-validator
Copy link

Hi @cyburgee,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@akka-ci
Copy link

akka-ci commented Apr 16, 2020

Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK TO TEST' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged.

For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask!

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) labels Apr 16, 2020
@akka-ci
Copy link

akka-ci commented Apr 16, 2020

Test FAILed.

!!! Couldn't read commit file !!!

@jrudolph
Copy link
Member

Rebased and fixed the test compilation error.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) labels Apr 22, 2020
@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Apr 22, 2020
@akka-ci
Copy link

akka-ci commented Apr 22, 2020

Test PASSed.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) labels Apr 22, 2020
@jrudolph jrudolph requested a review from raboof April 22, 2020 09:43
@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Apr 22, 2020
@akka-ci
Copy link

akka-ci commented Apr 22, 2020

Test PASSed.

@jrudolph
Copy link
Member

PLS BUILD

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) labels May 11, 2020
jrudolph
jrudolph approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again, @cyburgee.

@akka-ci akka-ci added needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR that is currently being validated by Jenkins labels May 11, 2020
@akka-ci
Copy link

akka-ci commented May 11, 2020

Test FAILed.

Pull request validation report

Failed Test Suites

Test result for 'akka-http-core / Pr-validation / ./ executeTests'

[info] ScalaTest
[info] Run completed in 4 minutes, 43 seconds.
[info] Total number of tests run: 1050
[info] Suites: completed 76, aborted 0  Scopes: pending 1
[info] Tests: succeeded 1046, failed 4, canceled 1, ignored 2, pending 55
[info] *** 4 TESTS FAILED ***
[error] Failed: Total 1050, Failed 4, Errors 0, Passed 1046, Ignored 2, Canceled 1, Pending 55
[error] Failed tests:
[error] 	akka.http.scaladsl.ClientServerSpec

@cyburgee @jrudolph
core: fix EOL detection for body part parsing
428877e 
Refs akka#2581

 * Improved the heuristic for detecting end of line character(s)
 * Added tests for UndefinedEndOfLineConfiguration

Co-authored-by: Johannes Rudolph <johannes.rudolph@gmail.com>
@akka-ci akka-ci added validating PR that is currently being validated by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) labels May 11, 2020
jrudolph pushed a commit to jrudolph/akka-http that referenced this pull request May 11, 2020
@cyburgee @jrudolph
[backport] core: fix EOL detection for body part parsing
139d0cd 
10.1 Backport of akka#3076

Refs akka#2581

 * Improved the heuristic for detecting end of line character(s)
 * Added tests for UndefinedEndOfLineConfiguration

Co-authored-by: Johannes Rudolph <johannes.rudolph@gmail.com>
(cherry picked from commit 428877e)
@akka-ci akka-ci added needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR that is currently being validated by Jenkins labels May 11, 2020
@akka-ci
Copy link

akka-ci commented May 11, 2020

Test FAILed.

Pull request validation report

Failed Test Suites

Test result for 'akka-http-core / Pr-validation / ./ executeTests'

[info] ScalaTest
[info] Run completed in 4 minutes, 39 seconds.
[info] Total number of tests run: 1050
[info] Suites: completed 76, aborted 0  Scopes: pending 1
[info] Tests: succeeded 1046, failed 4, canceled 1, ignored 2, pending 55
[info] *** 4 TESTS FAILED ***
[error] Failed: Total 1050, Failed 4, Errors 0, Passed 1046, Ignored 2, Canceled 1, Pending 55
[error] Failed tests:
[error] 	akka.http.scaladsl.ClientServerSpec

@jrudolph jrudolph mentioned this pull request May 11, 2020
Merged
@jrudolph
Copy link
Member

I try to reproduce the failures, these tests don't seem to fail in the backport (#3144).

raboof pushed a commit that referenced this pull request May 11, 2020
@jrudolph @cyburgee
[backport] core: fix EOL detection for body part parsing (#3144)
0d84f65 
10.1 Backport of #3076

Refs #2581

 * Improved the heuristic for detecting end of line character(s)
 * Added tests for UndefinedEndOfLineConfiguration

Co-authored-by: Johannes Rudolph <johannes.rudolph@gmail.com>
(cherry picked from commit 428877e)

Co-authored-by: Collin Burger <collin.e.burger@gmail.com>
@jrudolph
Copy link
Member

Should be rebuilt after #3145 is merged.

@jrudolph
Copy link
Member

jrudolph commented May 12, 2020 •
edited

PLS BUILD

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) labels May 12, 2020
ennru
ennru approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jrudolph
Copy link
Member

PLS BUILD

@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels May 13, 2020
@akka-ci
Copy link

akka-ci commented May 13, 2020

Test PASSed.

@jrudolph jrudolph merged commit 50b45eb into akka:master May 13, 2020
@jrudolph
Copy link
Member

Thanks a lot, @cyburgee.

@jrudolph jrudolph mentioned this pull request May 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrudolph jrudolph jrudolph approved these changes

@raboof raboof raboof approved these changes

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding needs-backport tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cyburgee @lightbend-cla-validator @akka-ci @jrudolph @raboof @ennru