Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document and dogfood using the attribute for websockets #3358

Merged
merged 8 commits into from Jul 10, 2020
Merged

Document and dogfood using the attribute for websockets #3358

merged 8 commits into from Jul 10, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Jul 7, 2020 •
edited

Refs #3278

@akka-ci akka-ci added the validating PR that is currently being validated by Jenkins label Jul 7, 2020
@raboof raboof mentioned this pull request Jul 7, 2020
Closed
@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Jul 7, 2020
@akka-ci
Copy link

akka-ci commented Jul 7, 2020

Test PASSed.

raboof and others added 6 commits July 8, 2020 16:51
@raboof
Introduce attribute for upgrading to websocket
c90b05c 
This only introduces the attributes. We still need to update utilities, tests
and documentation, but for that it's probably convenient to first introduce
directives to extract attributes, akka#3315
@raboof
header->attribute
cb5dccc
@jrudolph @raboof
Autoformatted code
ae699fe
@raboof
Document and dogfood the websockets attribute
ec33139
@raboof
Remove heading
52ab152
@raboof
Remove dead code in websocket TestServer
2b6684d
@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels Jul 8, 2020
@akka-ci
Copy link

akka-ci commented Jul 8, 2020

Test PASSed.

@raboof raboof marked this pull request as ready for review July 8, 2020 15:22
@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels Jul 8, 2020
@akka-ci
Copy link

akka-ci commented Jul 8, 2020

Test PASSed.

@raboof raboof requested a review from jrudolph July 9, 2020 08:05
jrudolph
jrudolph approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ennru
ennru approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

akka-http-core/src/main/scala/akka/http/scaladsl/model/ws/UpgradeToWebSocket.scala Outdated Show resolved Hide resolved
akka-http/src/main/scala/akka/http/javadsl/server/directives/WebSocketDirectives.scala Outdated Show resolved Hide resolved
akka-http/src/main/scala/akka/http/scaladsl/server/directives/WebSocketDirectives.scala Outdated Show resolved Hide resolved
@raboof @ennru
improved deprecation notes
7eb8c02 
Co-authored-by: Enno <458526+ennru@users.noreply.github.com>
@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels Jul 9, 2020
@akka-ci
Copy link

akka-ci commented Jul 9, 2020

Test PASSed.

@raboof raboof merged commit 8207959 into akka:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrudolph jrudolph jrudolph approved these changes

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@raboof @akka-ci @jrudolph @ennru