http2: support Strict entities in Http2SubStream #3824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs tests |
Actually, it cannot be observed from the outside, so I guess no particular tests are necessary. There are tests that examine sending Strict entities in general. |
This avoids materializing a stream for outgoing Strict entities.
jrudolph
force-pushed
the
support-strict-entities-in-substream
branch
from
e5d5076
to
5612e4e
Compare
akka-ci
added
validating
|
Test PASSed. |
raboof
approved these changes
Jun 2, 2021
|
|
||
| var httpFlow: Flow[ByteString, ByteString, Any] = _ | ||
| implicit var system: ActorSystem = _ | ||
| implicit var mat: ActorMaterializer = _ | ||
|
|
||
| val packedResponse = ByteString(-62, -63, -64, -65, -66) | ||
| val packedResponse = ByteString(1, 5, 0, 0) // a HEADERS frame with end_stream == true |
| // TODO: Check that buffer is not too much over the limit (which we might warn the user about) | ||
| // The problem here is that backpressure will only work properly if batch elements like | ||
| // ByteString have a reasonable size. | ||
| if (buffer.size < multiplexer.maxBytesToBufferPerSubstream && !inlet.hasBeenPulled && !inlet.isClosed) inlet.pull() | ||
| } | ||
| if (!upstreamClosed && buffer.size < multiplexer.maxBytesToBufferPerSubstream && !inlet.hasBeenPulled && !inlet.isClosed) inlet.pull() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids materializing a stream for outgoing Strict entities.
Another ready result from #3822.