http2: add client-side cancellation propagation delay #4027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrudolph
force-pushed
the
http2-client-cancellation-propagation
branch
from
4019398
to
99b766f
Compare
|
Hopefully would also fix #4050 which looks like a typical error => completion conversion because of stream cancellation. |
raboof
approved these changes
Mar 1, 2022
akka-http-core/src/main/scala/akka/http/impl/engine/http2/Http2Blueprint.scala
Outdated
Show resolved
Hide resolved
jrudolph
force-pushed
the
http2-client-cancellation-propagation
branch
from
99b766f
to
083fc1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid race conditions.
We might want to look into whether there's a better way to report errors like that.