New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move common settings to an autoplugin #409
Conversation
Test PASSed. |
LGTM, thanks for the fix. Very weird that this is how inThisBuild works there... Oh well |
I'll release RC1 again, so it has the proper version suffix. |
I don't think this was necessary. We set |
Why did we have crossPaths false anywhere in the first place...? Weird. I published the correct artifacts now (@2m's patch also works, but we should remove that |
Yes, we need to remove that. Otherwise, we might rely on the ordering of loading plugins. |
|
S3 upload what? We don't do a distribution here hm. |
Yes, you are right. Akka Http does not publish to S3. Akka does. And that is where |
Uhm, you mean removing it is fine, since we don't use it - we don't have a "release" (zip) here, |
Fixes #408
inThisBuild
sets project scope to the current build, but settings set in the/build.sbt
are added to the root project only.Instead moved common settings to an AutoPlugin that is applied to every project.