Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: http2-enable flag was not picking up the old one #4229

Merged
merged 1 commit into from Feb 20, 2023
Merged

fix: http2-enable flag was not picking up the old one #4229

merged 1 commit into from Feb 20, 2023

Conversation

johanandren
Copy link
Member

References #4228

patriknw
patriknw approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Strange. Back in the old days config resolve didn't include application conf override but that was very long since that was changed. Probably some resolve or fallback setup that is making this. Anyway, this new way is safer.

@johanandren johanandren merged commit b1c841b into main Feb 20, 2023
@johanandren johanandren deleted the wip-4228-backwards-compat-for-http2-enable-config branch February 20, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriknw patriknw patriknw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johanandren @patriknw