Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix fossa excludes using paths #4288

Merged
merged 1 commit into from Jul 26, 2023
Merged

Conversation

pvlugter
Copy link
Contributor

Fossa was not skipping the excluded targets. Couldn't figure out why or how to make target excludes work here. Switch to path excludes (as we're using for akka).

fossa analyze --output before:

18 projects scanned;  1 skipped,  17 succeeded,  0 failed,  17 analysis warnings

* scala project in "/Users/peter/dev/akka/akka-http/akka-http-bench-jmh/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-bill-of-materials/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-caching/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-compatibility-tests/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-core/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-marshallers-java/akka-http-jackson/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-marshallers-java/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-marshallers-scala/akka-http-spray-json/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-marshallers-scala/akka-http-xml/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-marshallers-scala/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-scalafix/scalafix-rules/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-testkit/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-tests/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http2-support/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-parsing/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/docs/target/scala-2.13/": skipped (non-production path filtering)

With path excludes it skips the excluded projects:

18 projects scanned;  3 skipped,  15 succeeded,  0 failed,  15 analysis warnings

* scala project in "/Users/peter/dev/akka/akka-http/akka-http-bill-of-materials/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-caching/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-core/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-marshallers-java/akka-http-jackson/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-marshallers-java/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-marshallers-scala/akka-http-spray-json/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-marshallers-scala/akka-http-xml/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-marshallers-scala/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-scalafix/scalafix-rules/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-testkit/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-tests/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http2-support/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-parsing/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/target/scala-2.13/": succeeded with 1 warning
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-bench-jmh/target/scala-2.13/": skipped (exclusion filters)
* scala project in "/Users/peter/dev/akka/akka-http/akka-http-compatibility-tests/target/scala-2.13/": skipped (exclusion filters)
* scala project in "/Users/peter/dev/akka/akka-http/docs/target/scala-2.13/": skipped (non-production path filtering)

Copy link
Member

@octonato octonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@octonato octonato merged commit cc2212d into akka:main Jul 26, 2023
11 checks passed
@pvlugter pvlugter deleted the fossa-excludes branch July 26, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants