fix: Fail-over to UTF-8 if Accept-Charset is invalid #4296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
force-pushed
the
wip-4295-invalid-accept-charset-causes-http-500
branch
from
dab225e
to
b0c7817
Compare
patriknw
approved these changes
Sep 20, 2023
| } catch { | ||
| case _: java.nio.charset.UnsupportedCharsetException => | ||
| // request contained an invalid charset name, fall back to UTF-8 | ||
| HttpCharsets.`UTF-8` |
There was a problem hiding this comment.
ok, so this would be the same as if the header was not specified? effectively ignoring the header if it's invalid, which is along the lines of the recommendation in https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept-Charset
patriknw
deleted the
wip-4295-invalid-accept-charset-causes-http-500
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #4295
Follows the suggestion in https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept-Charset and falls back to UTF-8 when the requested Accept-Charset is not a valid charset (instead of failing with a NIO exception and logging noise)