Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New authors script #477

Merged

Conversation

johanandren
Copy link
Member

No description provided.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) labels Nov 3, 2016
@akka-ci
Copy link

akka-ci commented Nov 3, 2016

Test FAILed.

@akka-ci akka-ci removed the validating PR that is currently being validated by Jenkins label Nov 3, 2016
* or if on non unixy os:
* scala authors.scala tag1 tag2
*
* requires scala 2.11.x+ and command line git on path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's in Scala, couldn't we just include it in sbt?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I guess, what would we gain from it though (unless we make something grander for releasing where it is a part)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it might be simpler to compile if there's no scala on the command line but on the other hand, if you don't need it a lot it might make sense to just keep it here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't even think of that since I always have. Good point. Hmm.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to make that change in this PR @johanandren ? :)
Sounds like a good idea 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah, lets merge this and I can do that later, given time, this is useful until then

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey 👍

@ktoso ktoso merged commit 05f4c01 into akka:master Nov 7, 2016
@ktoso
Copy link
Member

ktoso commented Nov 7, 2016

Thanks @johanandren :)

jedrekn pushed a commit to jedrekn/akka-http that referenced this pull request Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-attention Indicates a PR validation failure (set by CI infrastructure)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants