Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bumping to upgrade scala-xml to 2.1.0 #1106

Merged
merged 3 commits into from
Jan 12, 2023
Merged

bumping to upgrade scala-xml to 2.1.0 #1106

merged 3 commits into from
Jan 12, 2023

Conversation

franciscolopezsancho
Copy link
Contributor

@franciscolopezsancho
Copy link
Contributor Author

This way we only have scala-xml 2.1.0

sbt:akka-management-root> whatDependsOn org.scala-lang.modules scala-xml_2.12
[info] org.scala-lang.modules:scala-xml_2.12:2.1.0 [S]
[info]   +-org.scalatest:scalatest-core_2.12:3.2.12 [S]
[info]     +-org.scalatest:scalatest-diagrams_2.12:3.2.12 [S]
[info]     | +-org.scalatest:scalatest_2.12:3.2.12 [S]
[info]     |   +-com.lightbend.akka.management:akka-lease-kubernetes-int-test_2.12:1.2.0-14-7ac61825-20230112-1213-SNAPSHOT
[info]     |
[info]     +-org.scalatest:scalatest-featurespec_2.12:3.2.12 [S]
[info]     | +-org.scalatest:scalatest_2.12:3.2.12 [S]
[info]     |   +-com.lightbend.akka.management:akka-lease-kubernetes-int-test_2.12:1.2.0-14-7ac61825-20230112-1213-SNAPSHOT
[info]     |
[info]     +-org.scalatest:scalatest-flatspec_2.12:3.2.12 [S]
[info]     | +-org.scalatest:scalatest_2.12:3.2.12 [S]
[info]     |   +-com.lightbend.akka.management:akka-lease-kubernetes-int-test_2.12:1.2.0-14-7ac61825-20230112-1213-SNAPSHOT
[info]     |
[info]     +-org.scalatest:scalatest-freespec_2.12:3.2.12 [S]
[info]     | +-org.scalatest:scalatest_2.12:3.2.12 [S]
[info]     |   +-com.lightbend.akka.management:akka-lease-kubernetes-int-test_2.12:1.2.0-14-7ac61825-20230112-1213-SNAPSHOT
[info]     |
[info]     +-org.scalatest:scalatest-funspec_2.12:3.2.12 [S]
[info]     | +-org.scalatest:scalatest_2.12:3.2.12 [S]
[info]     |   +-com.lightbend.akka.management:akka-lease-kubernetes-int-test_2.12:1.2.0-14-7ac61825-20230112-1213-SNAPSHOT
[info]     |
[info]     +-org.scalatest:scalatest-funsuite_2.12:3.2.12 [S]
[info]     | +-org.scalatest:scalatest_2.12:3.2.12 [S]
[info]     |   +-com.lightbend.akka.management:akka-lease-kubernetes-int-test_2.12:1.2.0-14-7ac61825-20230112-1213-SNAPSHOT
[info]     |
[info]     +-org.scalatest:scalatest-matchers-core_2.12:3.2.12 [S]
[info]     | +-org.scalatest:scalatest-mustmatchers_2.12:3.2.12 [S]
[info]     | | +-org.scalatest:scalatest_2.12:3.2.12 [S]
[info]     | |   +-com.lightbend.akka.management:akka-lease-kubernetes-int-test_2.12:1.2.0-14-7ac61825-20230112-1213-SNAPSHOT
[info]     | |
[info]     | +-org.scalatest:scalatest-shouldmatchers_2.12:3.2.12 [S]
[info]     | | +-org.scalatest:scalatest_2.12:3.2.12 [S]
[info]     | |   +-com.lightbend.akka.management:akka-lease-kubernetes-int-test_2.12:1.2.0-14-7ac61825-20230112-1213-SNAPSHOT
[info]     | |
[info]     | +-org.scalatest:scalatest_2.12:3.2.12 [S]
[info]     |   +-com.lightbend.akka.management:akka-lease-kubernetes-int-test_2.12:1.2.0-14-7ac61825-20230112-1213-SNAPSHOT
[info]     |
[info]     +-org.scalatest:scalatest-propspec_2.12:3.2.12 [S]
[info]     | +-org.scalatest:scalatest_2.12:3.2.12 [S]
[info]     |   +-com.lightbend.akka.management:akka-lease-kubernetes-int-test_2.12:1.2.0-14-7ac61825-20230112-1213-SNAPSHOT
[info]     |
[info]     +-org.scalatest:scalatest-refspec_2.12:3.2.12 [S]
[info]     | +-org.scalatest:scalatest_2.12:3.2.12 [S]
[info]     |   +-com.lightbend.akka.management:akka-lease-kubernetes-int-test_2.12:1.2.0-14-7ac61825-20230112-1213-SNAPSHOT
[info]     |
[info]     +-org.scalatest:scalatest-wordspec_2.12:3.2.12 [S]
[info]     | +-org.scalatest:scalatest_2.12:3.2.12 [S]
[info]     |   +-com.lightbend.akka.management:akka-lease-kubernetes-int-test_2.12:1.2.0-14-7ac61825-20230112-1213-SNAPSHOT
[info]     |
[info]     +-org.scalatest:scalatest_2.12:3.2.12 [S]
[info]       +-com.lightbend.akka.management:akka-lease-kubernetes-int-test_2.12:1.2.0-14-7ac61825-20230112-1213-SNAPSHOT

@franciscolopezsancho franciscolopezsancho requested review from johanandren and ennru and removed request for johanandren January 12, 2023 11:25
ennru
ennru approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru
Copy link
Member

ennru commented Jan 12, 2023

Please update https://github.com/akka/akka-management/blob/main/.scala-steward.conf#L6 as well.

johanandren
johanandren approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johanandren johanandren merged commit 315afae into akka:main Jan 12, 2023
@johanandren johanandren added this to the 1.3.0-M1 milestone Jan 12, 2023
@johanandren johanandren modified the milestones: 1.3.0-M1, 1.3.0 Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

@johanandren johanandren johanandren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@franciscolopezsancho @ennru @johanandren