feat: Write pod cost to CRD #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
force-pushed
the
wip-pod-delete-crd-patriknw
branch
from
f5316fe
to
8702984
Compare
johanandren
reviewed
Apr 20, 2023
rolling-update-kubernetes/src/main/scala/akka/rollingupdate/kubernetes/KubernetesApiImpl.scala
Outdated
Show resolved
Hide resolved
rolling-update-kubernetes/src/main/scala/akka/rollingupdate/kubernetes/KubernetesApiImpl.scala
Show resolved
Hide resolved
rolling-update-kubernetes/src/main/scala/akka/rollingupdate/kubernetes/KubernetesApiImpl.scala
Show resolved
Hide resolved
rolling-update-kubernetes/src/main/scala/akka/rollingupdate/kubernetes/KubernetesApiImpl.scala
Outdated
Show resolved
Hide resolved
patriknw
commented
Apr 20, 2023
|
|
||
| log.debug("kubernetes access namespace: {}. Secure: {}", namespace, settings.secure) | ||
|
|
||
| override def updatePodDeletionCostAnnotation(podName: String, cost: Int): Future[Done] = { |
There was a problem hiding this comment.
This was "moved" from previous ApiRequests and PodDeletionCostAnnotator actor
|
|
||
| 201 Created if it works | ||
| */ | ||
| override def readOrCreatePodCostResource(crName: String): Future[PodCostResource] = { |
There was a problem hiding this comment.
These methods for reading and updating the CR are based on the corresponding in the lease module.
rolling-update-kubernetes/src/main/scala/akka/rollingupdate/kubernetes/KubernetesApiImpl.scala
Outdated
Show resolved
Hide resolved
patriknw
force-pushed
the
wip-pod-delete-crd-patriknw
branch
2 times, most recently
from
2cb3d9b
to
5984b10
Compare
johanandren
approved these changes
Apr 24, 2023
| if (normalized.length > 63) | ||
| throw new IllegalArgumentException(s"Too long resource name [$normalized]. At most 63 characters is accepted. " + | ||
| "A custom resource name can be defined in configuration `akka.rollingupdate.kubernetes.custom-resource.cr-name`.") | ||
| trim(normalized, List('-')) |
This was referenced Apr 24, 2023
patriknw
force-pushed
the
wip-pod-delete-crd-patriknw
branch
4 times, most recently
from
ab6a742
to
ca164ed
Compare
* alternative to adding the Kubernetes annotation directly to the pod resource in case allowing PATCH verb is a security concern * a separate Kubernetes operator with more privilages would watch the CR and update the pod resource with the annotation
patriknw
force-pushed
the
wip-pod-delete-crd-patriknw
branch
from
8656cb7
to
7800157
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: