Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS: Add tag-based filtering to ecs-service-discovery-async #634

Merged
merged 10 commits into from
May 8, 2020
Merged

AWS: Add tag-based filtering to ecs-service-discovery-async #634

merged 10 commits into from
May 8, 2020

Conversation

milanvdm
Copy link
Contributor

@milanvdm milanvdm commented Dec 18, 2019 •
edited

Purpose

Extends the aws-ecs-async discovery method to also be able to filter nodes based on tags.

Changes

  • Adds new tags configuration key
  • Filter based on tags configuration

Background Context

Be able to only form a cluster with specific tasks using certain tags

@milanvdm milanvdm changed the title Add tag based filtering to ecs-service-discovery-async Add tag-based filtering to ecs-service-discovery-async Dec 18, 2019
chbatey
chbatey approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@chbatey chbatey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

discovery-aws-api-async/src/main/resources/reference.conf Show resolved Hide resolved
@patriknw
Copy link
Member

There is a merge conflict here now

@milanvdm
Copy link
Contributor Author

Ill fix it when Im back from holidays

ennru
ennru approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru added this to the 1.0.7 milestone May 8, 2020
@ennru ennru added the t:aws label May 8, 2020
@ennru ennru changed the title Add tag-based filtering to ecs-service-discovery-async AWS: Add tag-based filtering to ecs-service-discovery-async May 8, 2020
@ennru ennru merged commit 353871c into akka:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

@chbatey chbatey chbatey approved these changes

@sebastianharko sebastianharko Awaiting requested review from sebastianharko

Assignees
No one assigned
Labels
t:aws
Projects
None yet
Milestone
1.0.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@milanvdm @patriknw @ennru @chbatey