Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed invalid AtomicWrites grouping + minor optimizations #508

Merged
merged 2 commits into from
Jul 9, 2019
Merged

fixed invalid AtomicWrites grouping + minor optimizations #508

merged 2 commits into from
Jul 9, 2019

Conversation

jsfwa
Copy link
Contributor

@jsfwa jsfwa commented Jun 8, 2019

Purpose

maxMessageBatchSize validation in asyncWriteMessages has been broken for a while, easily exceeding batch_size_fail_threshold_in_kb on C* side
Now it respects persistAll and persistAllAsync commands

@chbatey chbatey requested a review from patriknw June 17, 2019 07:51
chbatey
chbatey approved these changes Jun 17, 2019
View reviewed changes
Copy link
Member

@chbatey chbatey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jsfwa

@chbatey chbatey added this to the 0.99 milestone Jul 9, 2019
@chbatey chbatey merged commit 151ca0f into akka:master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chbatey chbatey chbatey approved these changes

@patriknw patriknw Awaiting requested review from patriknw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.99
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsfwa @chbatey