Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for multi-partition & mixed gaps #509

Merged
merged 8 commits into from
Jul 9, 2019
Merged

Added support for multi-partition & mixed gaps #509

merged 8 commits into from
Jul 9, 2019

Conversation

jsfwa
Copy link
Contributor

@jsfwa jsfwa commented Jun 10, 2019

Purpose

We were surprised that plugin could not handle huge gaps in event log, especially cross-partitions gaps

Changes

  • added support for multi-partition & mixed gaps
  • added option to disable synced requests to metadata table before replay\recovery (such requests are useless in a lot of cases)
  • added tests for any kind of gaps

chbatey
chbatey suggested changes Jun 17, 2019
View reviewed changes
Copy link
Member

@chbatey chbatey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the metadata change but otherwise LGTM.

What are causing these gaps? Unless you have events from an old version of the plugin there should
not be any gaps for events by persistenceId

core/src/main/resources/reference.conf Outdated Show resolved Hide resolved
core/src/main/resources/reference.conf Outdated Show resolved Hide resolved
core/src/main/scala/akka/persistence/cassandra/journal/CassandraRecovery.scala Outdated Show resolved Hide resolved
chbatey
chbatey approved these changes Jul 5, 2019
View reviewed changes
Copy link
Member

@chbatey chbatey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chbatey chbatey requested a review from patriknw July 5, 2019 12:39
@chbatey chbatey added this to the 0.99 milestone Jul 9, 2019
@chbatey chbatey merged commit 83c5f6f into akka:master Jul 9, 2019
@patriknw patriknw mentioned this pull request Dec 3, 2019
Merged
@patriknw
Copy link
Member

patriknw commented Dec 5, 2019

@jsfwa @chbatey Note that this PR was only merged to master and not backported to the release-0.x branch, i.e. it was not included in the 0.99 release. Does that mean that the feature wasn't needed in the end?

@chbatey chbatey removed this from the 0.99 milestone Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chbatey chbatey chbatey approved these changes

@patriknw patriknw Awaiting requested review from patriknw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsfwa @patriknw @chbatey