Cleaning up of snapshots and events before snapshots based on time and a # of snapshots #828
Conversation
core/src/main/scala/akka/persistence/cassandra/snapshot/CassandraSnapshotStore.scala
Show resolved
Hide resolved
core/src/main/scala/akka/persistence/cassandra/snapshot/CassandraSnapshotStore.scala
Outdated
Show resolved
Hide resolved
| def deleteBeforeSnapshot( | ||
| persistenceId: String, | ||
| snapshotsToKeep: Int, | ||
| keepAfter: Long): Future[Option[SnapshotMetadata]] = { |
There was a problem hiding this comment.
Hard to parse what it does from name/docs but I'm not sure I can come up with anything better...
deleteSnapshotsBefore(persistenceId, unixTimestamp, nrSnapshotsToKeep)?
There was a problem hiding this comment.
Yah i struggled to describe it.
Just having a timestamp makes it easy to understand "delete all snapshots older than X" but is an API that will lead to ppl deleting all their snapshots!
|
|
||
| /** | ||
| * Deletes all but the last N snapshots and deletes all events before this snapshot | ||
| * Does not delete from the tag_views table |
There was a problem hiding this comment.
Perhaps additional caveat about consequences for this? Events by tag would fail if you run it and see a tag for a message that is not there?
There was a problem hiding this comment.
I don't think it'll fail, it doesn't reconcile that way around. Only messages to tag_views table. I will add warnings tho
core/src/main/scala/akka/persistence/cassandra/cleanup/Cleanup.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/akka/persistence/cassandra/journal/CassandraJournal.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/akka/persistence/cassandra/snapshot/CassandraSnapshotStatements.scala
Show resolved
Hide resolved
| val allRows: Source[Row, NotUsed] = session.select(ps.bind(persistenceId)) | ||
| @volatile var count = 0 | ||
| allRows | ||
| .takeWhile { row => |
There was a problem hiding this comment.
could we skip the count hack with:
allRows
.take(snapshotsToKeep)
.takeWhile { row =>
?
There was a problem hiding this comment.
No as we may wan to keep more than snapshotsToKeep if they are all newer than the toKeep time
chbatey
force-pushed
the
wip-chbatey-cleanup-on-snapshots
branch
from
ae39644
to
f080bd1
Compare
Cleanup snapshots and events from before a configured snapshot (#828) (for 0.x branch)
No description provided.