fix not working JournalDaoStreamMessagesMemoryTest #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johanandren @octonato would you like to take a look? |
|
Was this test not being run? How was it passing before? |
|
@octonato |
johanandren
approved these changes
May 7, 2024
|
I see I missed one thing though, we lost the |
johanandren
added a commit
that referenced
this pull request
May 7, 2024
…agesMemoryTest Accidentally removed in #831
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JournalDaoStreamMessagesMemoryTest didn't work in the newDao because it uses legacyDao, we could create dao instance via reflection to make it works.