fix: Start from earliest slice for downscaling scenario #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* start from earliest slice when projection key is changed
patriknw
force-pushed
the
wip-downscaling2-patriknw
branch
from
30150fc
to
93fe817
Compare
pvlugter
reviewed
Sep 18, 2023
akka-projection-r2dbc/src/it/scala/akka/projection/r2dbc/ChangeSliceRangesSpec.scala
Outdated
Show resolved
Hide resolved
| // offset of the earliest slice | ||
| val latestBySlice = newState.latestBySlice | ||
| val earliest = latestBySlice.minBy(_.timestamp).timestamp | ||
| Some(TimestampOffset(earliest, Map.empty)) |
There was a problem hiding this comment.
For the latest offset, the seen map is populated. When I was experimenting with the earliest or latest-by-split offsets, I also ended up creating the seen map from byPid for the selected offset here. Shouldn't affect behaviour when eventually deduplicated, but I think at least the metrics were confused (inactive projections had growing consumer lag metrics).
There was a problem hiding this comment.
I don't think it's important to reconstruct it in this case, but I added the obvious from earliest record. 4ab18c3
Co-authored-by: Peter Vlugter <59895+pvlugter@users.noreply.github.com>
|
@pvlugter @johanandren Shall we go with this? So that we include it in our testing? |
pvlugter
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New iteration of #995 and #1004