Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDBC documentation #273

Merged
merged 3 commits into from
Jun 26, 2020
Merged

JDBC documentation #273

merged 3 commits into from
Jun 26, 2020

Conversation

octonato
Copy link
Member

References #23

@octonato octonato force-pushed the rgc/jdbc-docs branch 3 times, most recently from f3900b5 to d0efffd Compare June 25, 2020 15:02
patriknw
patriknw reviewed Jun 25, 2020
View reviewed changes
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

akka-projection-jdbc/src/main/resources/reference.conf Outdated Show resolved Hide resolved
akka-projection-jdbc/src/main/scala/akka/projection/jdbc/javadsl/JdbcHandler.scala Outdated Show resolved Hide resolved
docs/src/main/paradox/jdbc.md Outdated Show resolved Hide resolved
docs/src/main/paradox/jdbc.md Outdated Show resolved Hide resolved
docs/src/main/paradox/jdbc.md Outdated Show resolved Hide resolved
docs/src/main/paradox/jdbc.md Show resolved Hide resolved
docs/src/main/paradox/jdbc.md Outdated Show resolved Hide resolved
docs/src/main/paradox/jdbc.md Show resolved Hide resolved
examples/src/test/scala/docs/jdbc/JdbcProjectionDocExample.scala Show resolved Hide resolved
@octonato octonato force-pushed the rgc/jdbc-docs branch 2 times, most recently from 75aa87f to 42c23c0 Compare June 25, 2020 17:31
@octonato octonato marked this pull request as ready for review June 25, 2020 20:18
patriknw
patriknw reviewed Jun 26, 2020
View reviewed changes
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good, just a few small things...

docs/src/main/paradox/jdbc.md Outdated Show resolved Hide resolved
docs/src/main/paradox/jdbc.md Outdated Show resolved Hide resolved
docs/src/main/paradox/jdbc.md Show resolved Hide resolved
docs/src/main/paradox/jdbc.md Outdated Show resolved Hide resolved
docs/src/main/paradox/jdbc.md Show resolved Hide resolved
This was referenced Jun 26, 2020
Merged
Closed
patriknw
patriknw approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patriknw patriknw merged commit 1802fec into master Jun 26, 2020
@patriknw patriknw deleted the rgc/jdbc-docs branch June 26, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriknw patriknw patriknw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@octonato @patriknw