Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CiReleasePlugin to requires in Common #552

Merged
merged 1 commit into from
May 12, 2021
Merged

add CiReleasePlugin to requires in Common #552

merged 1 commit into from
May 12, 2021

Conversation

patriknw
Copy link
Member

Seems to work without this, but I think this is more correct. Original suggestion from @2m in https://gitter.im/sbt/sbt?at=5a4ed1abba39a53f1ad9a1fb

2m
2m approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :) as far as I remember this establishes an order between setting application across plugins. So now in Common it is possible to transform setting values, that have been applied in CiReleasePlugin.

@patriknw
Copy link
Member Author

Thanks for confirming

@patriknw patriknw merged commit 0f9516d into master May 12, 2021
@patriknw patriknw deleted the wip-CiReleasePlugin-patriknw branch May 12, 2021 06:19
@patriknw patriknw added this to the 1.2.1 milestone May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2m 2m 2m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@patriknw @2m