Improve ergonomics of creating GrpcReadJournal, #703 #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
approved these changes
Oct 12, 2022
| @@ -108,7 +105,7 @@ public static void init(ActorSystem<?> system) { | |||
| int numberOfProjectionInstances = 4; | |||
| String projectionName = "cart-events"; | |||
| List<Pair<Integer, Integer>> sliceRanges = Persistence.get(system).getSliceRanges(numberOfProjectionInstances); | |||
| String streamId = "cart"; | |||
| String streamId = system.settings().config().getString("akka.projection.grpc.consumer.stream-id"); | |||
There was a problem hiding this comment.
Should we make the streamId a public field on GrpcReadJournal, so that even if it needs to be passed to the source provider at least this isn't needed and you know it's the same used for the journal?
There was a problem hiding this comment.
Det låter som en bra ide. Så parametern till SourceProvider blir eventsBySlicesQuery.streamId.
* builder style is used also for grpc client settings
patriknw
force-pushed
the
wip-703-ergo-patriknw
branch
from
f822aa7
to
d581fc1
Compare
johanandren
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because on top of other PR, but otherwise ready for review.
Refs #703