Document gRPC client lifecycle, #702 #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After too much tinkering of this I came to the conclusion that we should only document it. It's anyway working in the "right" way if following our code examples.
I first tried to bind the lifecycle to the lifecycle of the Projection instance, but it's anyway not enforced to be one GrpcReadJournal instance per Projection instance.
Then I explored the possibility to reuse clients for the same
GrpcClientSettingsand thereby enforce single instance per target producer and lifecycle bound to ActorSystem. That didn't work out because GrpcClientSettings is very open ended and not possible to use as key for such registry.References #702