Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build for Scala 2.13 #159

Merged
merged 2 commits into from Jun 13, 2019
Merged

Build for Scala 2.13 #159

merged 2 commits into from Jun 13, 2019

Conversation

liff
Copy link
Contributor

@liff liff commented Jun 13, 2019

Purpose

Add support for Scala 2.13.

References

Prepares for #147.

Changes

  • Add Scala 2.13.0 to cross version list
  • Modify compiler flags to be compatible across different Scala versions
  • Remove obsolete usage of Unit term
  • Update scalatest to 3.0.8
  • Update akka to 2.5.23
  • Update akka-mock-scheduler to 0.5.5
  • Change jdk from oraclejdk8 to openjdk8 in Travis CI as oraclejdk8 seems to have stopped working

Background Context

Scala 2.13.0 was released on June 11.

@ennru
Copy link
Member

ennru commented Jun 13, 2019

Please add a compilation step with Scala 2.13 for Travis, as well.

ennru
ennru approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru changed the title Build on Scala 2.13 Build for Scala 2.13 Jun 13, 2019
@ennru ennru merged commit 2e2fc5a into akka:master Jun 13, 2019
@ennru
Copy link
Member

ennru commented Jun 13, 2019

Thank you!

@2m
Copy link
Member

2m commented Jun 19, 2019

It took as a couple of back-and-forths with Travis, but now it is convinced that snapshots for 2.13 should be published. Here is the first one: http://central.maven.org/maven2/com/typesafe/akka/akka-stream-contrib_2.13/0.9+63-700bb5c4/

Thanks again for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liff @ennru @2m