Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would it be possible to idleTimeout set in a directive #20007

Closed
ktoso opened this issue Mar 10, 2016 · 6 comments
Closed

Would it be possible to idleTimeout set in a directive #20007

ktoso opened this issue Mar 10, 2016 · 6 comments
Labels
discuss Tickets that need some discussion before proceeding. Not decided if it's a good idea. help wanted Issues that the core team will likely not have time to work on nice-to-have (low-prio) Tasks which make sense, however are not very high priority, feel free to help out! t:http
Milestone

Comments

@ktoso
Copy link
Member

ktoso commented Mar 10, 2016

Interesting question, as we have RequestTimeouts, however idleTimeout is confusing a lot of people nowadays. We'll not log DEBUG soon already, but with websockets people most likely will want to have long lived ones actually...

We should investigate what it would take to have a withoutIdleTimeout {} directive etc.

☝️ March 11, 2016 12:35 AM

// I did not think it through from an impl perspective, but idea is interesting.

@ktoso ktoso added 0 - new Ticket is unclear on it's purpose or if it is valid or not t:http discuss Tickets that need some discussion before proceeding. Not decided if it's a good idea. labels Mar 10, 2016
@rkuhn
Copy link
Contributor

rkuhn commented Mar 21, 2016

Such a directive only makes sense for requests that govern the whole remainder of the connection’s lifecycle—normal requests are ephemeral and have nothing to say on the more long-lived connection. Since websockets are the only example, it would make sense to leave idleTimeout handling of websocket connections to the websocket code.

@ktoso
Copy link
Member Author

ktoso commented Mar 21, 2016

Yes, it only makes sense for by-definition one-request on this connection, however there's a popular style of API those represent: streaming responses.

One prominent example of such APIs that might end up being idle for quite a while (i.e. I want longer timeout for these) are APIs that are like Twitter's statuses/filter - if I filter for #akka and no one is tweeting that, I don't want to be disconnected after a minute, for others 1 minute of inactivity would be weird and I'd like to disconnect for example.

Some endpoints might be set up to be long polling ready, others not.

So I think we need it not only for websockets, but also for normal request/response – esp. since we keep talking about streaming :-)

@rkuhn
Copy link
Contributor

rkuhn commented Mar 21, 2016

Ah, right, I see. This calls for the ability to send a SetIdleTimeout messages through the response pipeline to reconfigure the timeout handling stage.

@ktoso ktoso added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted help wanted Issues that the core team will likely not have time to work on nice-to-have (low-prio) Tasks which make sense, however are not very high priority, feel free to help out! and removed 0 - new Ticket is unclear on it's purpose or if it is valid or not labels May 18, 2016
@ktoso
Copy link
Member Author

ktoso commented May 18, 2016

We won't be able to focus on this ticket soon. Up for grabs! Anyone? :)

@ktoso ktoso added this to the http-backlog milestone May 18, 2016
@rleibman
Copy link

I'd like to take a look at it. Would you mind telling me what you have in mind and any implementation ideas you have?

@ktoso ktoso removed the 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted label Sep 8, 2016
@ktoso
Copy link
Member Author

ktoso commented Sep 8, 2016

Ticket moved to github.com/akka/akka-http
Rationale for the move discussed here: akka/akka-meta#27

If you are interested in contributing or tracking this issue, please comment in akka-http instead from now on :-)

@ktoso ktoso closed this as completed Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Tickets that need some discussion before proceeding. Not decided if it's a good idea. help wanted Issues that the core team will likely not have time to work on nice-to-have (low-prio) Tasks which make sense, however are not very high priority, feel free to help out! t:http
Projects
None yet
Development

No branches or pull requests

3 participants