Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent OSGi from filtering out classes when releasing #20583

Closed
johanandren opened this issue May 20, 2016 · 2 comments
Closed

Prevent OSGi from filtering out classes when releasing #20583

johanandren opened this issue May 20, 2016 · 2 comments
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:build
Milestone
2.4.x

Comments

@johanandren
Copy link
Member

johanandren commented May 20, 2016 •
edited by patriknw
Loading

To prevent the big fiasco of missing classes in 2.4.5 from ever happening again we should make the build fail or just not omit classes.
@johanandren
Copy link
Member Author

I first started out investigating if we could make the sbt-osgi plugin fail when omitting files rather than silently dropping them but I think that it is because of us configuring OsgiKeys.privatePackage to be akka.osgi.impl rather than leave as default. If it is default omitted classes will be included but not available as public API (which I think had helpled with the 2.4.5-problem).

Maybe we could omit that privatePackage setting and have everything not explicitly published just not available as public API for people who use OSGi. Could still lead to problems, but users who don't use OSGi would not be affected as far as I understand.

@patriknw patriknw added this to the 2.4.x milestone May 24, 2016
@patriknw patriknw added the 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted label May 24, 2016
@ktoso ktoso mentioned this issue Aug 3, 2016
Closed
@patriknw
Copy link
Member

Obsolete, see #28304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:build
Projects
None yet
Milestone
2.4.x
Development

No branches or pull requests
2 participants
@patriknw @johanandren