Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish multi-jvm cluster helpers (i.e. MultiNodeClusterSpec) as a dedicated package. #23945

Open
e-kolpakov opened this issue Nov 8, 2017 · 4 comments
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:cluster t:testing

Comments

@e-kolpakov
Copy link

Akka cluster docs contain some instructions on testing cluster applications, but the apporach suggested there is very barebone as it basically requires managing cluster state by hand.

However, akka-cluster multi-jvm tests contain a much more sophisticated test helpers that allow:

Unfortunately all that goodness is locked in a package that is not published. It would be great to have access to such tools as part of akka-multi-node-testkit or a dedicated package.

@patriknw
Copy link
Member

Most of this can be done with awaitAssert and cluster.state, so I’m not sure it’s needed to create abstractions on top of that. The documentation can probably be improved though, with examples for these typical things.

@e-kolpakov
Copy link
Author

@packtpartner ok, let me rephrase this than - does it make sense to include helpers for typical scenarios into the testkit? I believe it would be a net loss to everyone to reimplement "cluster up" and "member joined" checks using cluster state.

Also, I might be able to allocate some time for submitting such helpers as open-source pull request, but I'd like to get green light for that feature before starting to work on it. Is this a good place to discuss it, or should I use something else (JIRA/gitter channel/etc.)?

@patriknw
Copy link
Member

Give it a try to write a few such helpers in a test in akka-cluster/src/test/scala and I’ll judge if they deserve a new akka-cluster-testkit module or should just be included as snippets in docs.

@ktoso ktoso added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:cluster t:testing labels Nov 13, 2017
@sergiy0
Copy link
Contributor

sergiy0 commented Nov 24, 2017

I'm also considering MultiNodeClusterSpec as very helpful and voting for publishing it in some way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:cluster t:testing
Projects
None yet
Development

No branches or pull requests

4 participants