Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of Thread.currentThread.getContextClassLoader and sbt run #24098

Open
raboof opened this issue Dec 4, 2017 · 5 comments
Open

Use of Thread.currentThread.getContextClassLoader and sbt run #24098

raboof opened this issue Dec 4, 2017 · 5 comments
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:build

Comments

@raboof
Copy link
Member

raboof commented Dec 4, 2017

If available and unless otherwise specified, our serialization uses the Thread.currentThread.getContextClassLoader captured while constructing the ActorSystem.

This leads to trouble when Thread.currentThread.getContextClassLoader cannot resolve basic classes such as scala.Int, as is the case when using sbt run in recent versions of sbt, which can be pretty hard to spot.

This sounds like an upstream issue in sbt, but if it persists we might want to find a way to reduce how this affects Akka users.
@ktoso
Copy link
Member

ktoso commented Dec 13, 2017

Keeping ticket around until fixed in sbt/sbt#3736

@ktoso ktoso added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:build labels Dec 13, 2017
@raboof
Copy link
Member Author

raboof commented Dec 22, 2017

No need to fix in akka, will be fixed in sbt 1.1.1

@raboof raboof closed this as completed Dec 22, 2017
@raboof
Copy link
Member Author

raboof commented Jan 6, 2018

Looks like this is fixed in the just-released sbt 1.1.0 even!

@ktoso
Copy link
Member

ktoso commented Jan 6, 2018

Oh awesome :)

@raboof
Copy link
Member Author

raboof commented May 30, 2018

It seems like this issue (or something suspiciously like it) has resurfaced between sbt 1.1.4 and 1.1.5...

@raboof raboof reopened this May 30, 2018
@raboof raboof mentioned this issue May 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ktoso @raboof