Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic module names seem dropped, osgi plugin at fault? #24520

Closed
ktoso opened this issue Feb 10, 2018 · 3 comments
Closed

automatic module names seem dropped, osgi plugin at fault? #24520

ktoso opened this issue Feb 10, 2018 · 3 comments
Milestone

Comments

@ktoso
Copy link
Member

ktoso commented Feb 10, 2018

Seems not all modules have safely kept the Automatic-Module-Name that is needed in order to use Akka as modules:

$ unzip akka-actor_2.12-2.5.9.jar > /dev/null
replace META-INF/MANIFEST.MF? [y]es, [n]o, [A]ll, [N]one, [r]ename: A


$ cat META-INF/MANIFEST.MF | grep Name
Bundle-Name: akka-actor
Bundle-SymbolicName: com.typesafe.akka.actor <<< bad, where's the automatic module name ?
ktoso @ 月/Users/ktoso/Downloads [master*]
$ unzip akka-actor-typed_2.12-2.5.9.jar > /dev/null
replace META-INF/MANIFEST.MF? [y]es, [n]o, [A]ll, [N]one, [r]ename: A

$ cat META-INF/MANIFEST.MF | grep Name
Automatic-Module-Name: akka.actor.typed <<<< good
 <<< semi bad, where's the osgi names?

We should fix this before next release I propose.

@ktoso ktoso added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding t:build bug labels Feb 10, 2018
@ktoso ktoso added this to the 2.5.10 milestone Feb 10, 2018
@ktoso
Copy link
Member Author

ktoso commented Feb 10, 2018

Note to self, check the same for Akka-HTTP (and Alpakka later)

@xuning97
Copy link

Need this in our project to create an easy-to-distribute java application, thanks

@ktoso
Copy link
Member Author

ktoso commented Feb 13, 2018

Fixed the sbt osgi plugin so our build is correct again

@ktoso ktoso removed 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants