Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify typed props #27150

Open
johanandren opened this issue Jun 16, 2019 · 0 comments
Open

Simplify typed props #27150

johanandren opened this issue Jun 16, 2019 · 0 comments
Labels
discuss-design Design discussion would be good t:typed

Comments

@johanandren
Copy link
Member

Currently the typed Props is a List structure, where new elements for the same type of key wins but old elements are kept in the list, a bit like the stream attributes. When we construct the actor we search for the first element. Additionally there seems to be some methods that are not used at all or only used from tests (allOf, filterNot).

Every time I look at the typed props I have to spend a while to figure out how they work and why. Would it be simpler if it was just an internal immutable map with some key and an ugly typecast of the actual value instead, or some other built in datastructure for that part?

@johanandren johanandren added t:typed discuss-design Design discussion would be good labels Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss-design Design discussion would be good t:typed
Projects
None yet
Development

No branches or pull requests

1 participant