-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestKit for Persistence Query #28519
Comments
@patriknw I am a bit confused of what is expected. Then I think that just implementing support of PersistenceQuery for the new memory journal should be enough. Then users would be able to do their checks obtaining ReadJournal instance. |
The idea is that the new memory journal would implement the queries, such as eventsByPersistenceId and eventsByTag. You can look at the leveldb journal for inspiration. |
Ok great, I already started, looks like its almost working from the box :) |
There is no way of showing that the event was removed when you use for example |
@patriknw one more thing... in current implementation of the testkit the highest sequence number is preserved separately by each persistence id, so for each persistence id they start from 0. When we do persistence query by tag (which may get events with different persistence ids), the ordering by sequence number may give several events with the same seq number. Is that also expected? |
The ordering for eventsByTag is only promised per persistenceId so they arrive in seqNr order, but best if you sort them by timestamp so that events for different persistenceId are interleaved. If you keep |
First step would be to add query support to the new memory journal #26825
Not sure we need much more since ordinary Streams testkit can be used, but we can discuss ideas.
The text was updated successfully, but these errors were encountered: