Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doubly dilated timeouts in typed test probe #30033

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Doubly dilated timeouts in typed test probe #30033

merged 1 commit into from
Feb 22, 2021

Conversation

johanandren
Copy link
Member

@johanandren johanandren commented Feb 15, 2021 •
edited

References #30021

The settings.SingleExpectDefaultTimeout and settings.ExpectNoMessageDefaultTimeout are already dilated, so don't dilate that further

@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR is currently being validated by Jenkins labels Feb 15, 2021
@akka-ci
Copy link

akka-ci commented Feb 15, 2021

Test PASSed.

patriknw
patriknw approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patriknw patriknw added the 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding label Feb 22, 2021
@johanandren johanandren merged commit 477dc7f into akka:master Feb 22, 2021
@johanandren johanandren deleted the wip-30021-incorrect-testkit-timeout-dilation branch February 22, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriknw patriknw patriknw approved these changes

@chbatey chbatey chbatey approved these changes

Assignees
No one assigned
Labels
2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@johanandren @akka-ci @patriknw @chbatey