Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source location in a few more stages #30039

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Source location in a few more stages #30039

merged 1 commit into from
Feb 22, 2021

Conversation

johanandren
Copy link
Member

Looking for more places where we accidentally use GraphStage.toString on a more or less hot path (follow up after #30022 ) I found two stages, which also can benefit from source location so updated those.

@akka-ci akka-ci added the validating PR is currently being validated by Jenkins label Feb 16, 2021
patriknw
patriknw approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch

@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR is currently being validated by Jenkins labels Feb 16, 2021
@akka-ci
Copy link

akka-ci commented Feb 16, 2021

Test PASSed.

@patriknw patriknw added the 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding label Feb 22, 2021
@patriknw patriknw added this to the 2.6.13 milestone Feb 22, 2021
@patriknw patriknw mentioned this pull request Feb 22, 2021
Closed
jrudolph
jrudolph approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, somewhat hard to find these ones because of the auto-toString

@johanandren johanandren merged commit 8dfb4a7 into akka:master Feb 22, 2021
@johanandren johanandren deleted the wip-some-more-graph-stage-toString-removals branch February 22, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrudolph jrudolph jrudolph approved these changes

@patriknw patriknw patriknw approved these changes

Assignees
No one assigned
Labels
2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding t:stream tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
2.6.13
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@johanandren @akka-ci @jrudolph @patriknw