Fail fix in ClusterShardingPreparingForShutdownSpec #30041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akka-ci
added
validating
|
Test FAILed. |
akka-ci
added
validating
|
Test PASSed. |
chbatey
approved these changes
Feb 17, 2021
johanandren
deleted the
wip-30037-cluster-sharding-preparing-for-shutdown-spec-fail
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #30037
Not 100% sure but I think the problem is that sometimes the shard coordinator state ddata write fails when one out of three nodes is shutting down so that the allocation of the shard and the message to the shard is dropped, the test optimistically expects all messages to sharding to arrive and has failed a couple of times. Retrying that message through sharding fixes it.