Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update manifestInfo docs #30056

Merged
merged 2 commits into from
Feb 22, 2021
Merged

Update manifestInfo docs #30056

merged 2 commits into from
Feb 22, 2021

Conversation

ignasi35
Copy link
Member

References #30044

@akka-ci akka-ci added the validating PR is currently being validated by Jenkins label Feb 22, 2021
@ignasi35 @johanandren
Update akka-docs/src/main/paradox/common/binary-compatibility-rules.md
a8fa87e 
Co-authored-by: Johan Andrén <johan@markatta.com>
@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR is currently being validated by Jenkins labels Feb 22, 2021
@akka-ci
Copy link

akka-ci commented Feb 22, 2021

Test PASSed.

1 similar comment
@akka-ci
Copy link

akka-ci commented Feb 22, 2021

Test PASSed.

@johanandren johanandren added the 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding label Feb 22, 2021
patriknw
patriknw approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akka-docs/src/main/paradox/common/binary-compatibility-rules.md
You are using version 2.6.6 of Akka, but it appears you (perhaps indirectly) also depend on older versions
of related artifacts. You can solve this by adding an explicit dependency on version 2.6.6 of the
[akka-persistence-query] artifacts to your project. Here's a complete collection of detected
artifacts: (2.5.3, [akka-persistence-query]), (2.6.6, [akka-actor, akka-cluster]).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

real example would include more stuff here, but good to keep it simple in the docs

@patriknw patriknw merged commit ac53091 into akka:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriknw patriknw patriknw approved these changes

@johanandren johanandren johanandren approved these changes

Assignees
No one assigned
Labels
2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ignasi35 @akka-ci @patriknw @johanandren