Add slice queries to Persistence TestKit #30995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* to make it feature comatible with currentEventsByTag * simplifies some usage in downstream projects
* to make it feature comatible with the tagged queries * simplifies some usage in downstream projects
patriknw
added
the
2 - pick next
jrudolph
approved these changes
Dec 16, 2021
johanandren
reviewed
Dec 16, 2021
|
|
||
| Source(store.values.toVector.filter(bySliceFromOffset).sortBy(_.globalOffset)) | ||
| .concat(changesSource) | ||
| .filter(bySliceFromOffsetNotDeleted) |
There was a problem hiding this comment.
This accesses mutable state from some other thread than the synchronized method call. Perhaps capturing the store as it was when the method was called is best? If not, make the store field volatile?
There was a problem hiding this comment.
@johanandren thanks, fixed in b2bb9ef
johanandren
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split in two commits if you prefer to review them separately.