Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying ClusterSingletonManagerSettings programatically in typed not possible #32379

Closed
johanandren opened this issue Apr 11, 2024 · 5 comments

Comments

@johanandren
Copy link
Member

I could be missing something but I can't find anywhere it is possible to specify akka.cluster.typed.ClusterSingletonManagerSettings when setting up a typed singleton. We do have API in typed sharding accepting it to configure the coordinator singleton though.

@patriknw
Copy link
Member

SingletonActor has withSettings

@johanandren
Copy link
Member Author

johanandren commented Apr 12, 2024

That accepts akka.cluster.typed.ClusterSingletonSettings not akka.cluster.typed.ClusterSingletonManagerSettings. We could maybe add an optional managerSettings to the akka.cluster.typed.ClusterSingletonSettings for minimal impact.

Quite confusing, there seems to be some overlap between the two settings classes as well (role, removalMargin,handoverInterval) but other settings are only in either of them (leaseSettings, singletonName, bufferSize, singletonIdentificationInterval)

@patriknw
Copy link
Member

I see, what is it you are missing in ClusterSingletonSettings that would be defined in the ClusterSingletonManagerSettings?

I don't know exactly, but in classic if had a clear separation between proxy and manager, which we collapsed in Typed, but I'm not sure why we have ClusterSingletonManagerSettings. Maybe something with sharding as well.

@johanandren
Copy link
Member Author

So we should maybe just add the settings that are in ClusterSingletonManagerSettings to ClusterSingletonSettings instead.

For the record the specific use case that lead to opening this issue was to be able to specify lease settings for a specific singleton.

@johanandren
Copy link
Member Author

Not sure what I was talking about, leaseSettings are in akka.cluster.typed.ClusterSingletonSettings, not sure any of the others are important to programatically configure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants