Align Confluent Platform version to 6.0.0 #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
References #1223 |
ignasi35
reviewed
Oct 9, 2020
| @@ -32,6 +31,7 @@ | |||
|
|
|||
| private static final String STARTER_SCRIPT = "/testcontainers_start.sh"; | |||
|
|
|||
| // Align this with testkit/src/main/resources/reference.conf | |||
There was a problem hiding this comment.
Super off-topic: it'd be great if we had a comment indicating CP stands for Confluent Platform
There was a problem hiding this comment.
I'm talking about the name of this constant: DEFAULT_CP_PLATFORM_VERSION
There was a problem hiding this comment.
That's an artifact of this type which was from https://github.com/testcontainers/testcontainers-java and modified for our purposes.
ignasi35
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1106